Skip to content

chore(quest): plan tuples inside other types for the exporter - #223

Merged
kixelated merged 1 commit into
mainfrom
quest-plan/ffi-tuples
Oct 29, 2026
Merged

kixelated merged 1 commit into
mainfrom
quest-plan/ffi-tuples

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

This adds quest/m1/ffi-export/tuples.md [M], a follow-up from #213. A tuple should cross wherever its elements map, as an iterator's or Vec's item, inside an Option or Result, or as a field or parameter, not only as a function's whole return.

  • Consumer: hang's catalog::Audio::ranked and catalog::Video::ranked. They return impl Iterator<Item = (&String, &AudioConfig)>, which feat(ffi): return a finite core or alloc iterator as the array of its items #213 collects into an array but refuses for the tuple.
  • Also unblocked: moq-net's stats::Snapshot::{control, traffic, sessions} and moq-mux's codec::annexb::find_start_code fail on the same refusal, so their excludes in ffi/moq/ffi.toml go too.
  • Placement: it is a child of the m1 exporter epic, ranked with the census refusals after the sessions moq waits on and before the generator quests. That follows the epic's rule: census refusals and what moq waits on first, then the runtime, then the generators.
  • Search: no existing quest or open PR covers ffi tuples. The quest tree mentions tuples only under the TypeScript translator's byte-view work.
  • Open in the quest's Plan: whether a whole tuple return keeps its out pointers (no break) or becomes the new C struct (one rule, with a MIGRATE.md entry).

Only quest files change. quest check and just check pass.

🤖 Generated with Claude Code

(Written by Claude Opus 5.5)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T14:51:41.769606Z 63feea4 PR opened
🔒 Security Review ✅ Completed 2026-10-29T14:52:08.158208Z 63feea4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: 63feea43def30efeef2a19b69f84061723633054.

No actionable bugs found in this plan-only change. Extending tuple values compositionally is a sensible way to unblock the listed iterator, vector and optional results; the named exclusions match the current FFI configuration. Keeping existing whole-return out parameters is the lower-risk compatibility option, while the proposed value structs can handle nested tuples. The explicit migration requirement if that ABI changes is appropriate.

Verification limits: static review of the plan, parent exporter requirements and FFI exclusions only. No implementation, generated bindings, census or differential tests were run or validated; ownership/cleanup of nested values and the final ABI choice still need implementation-level verification.

(Written by review (OpenAI))

@kixelated
kixelated merged commit 595d34f into main Oct 29, 2026
1 check passed
@kixelated
kixelated deleted the quest-plan/ffi-tuples branch October 29, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant