Repository navigation
chore(quest): plan tuples inside other types for the exporter - #223
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: 63feea43def30efeef2a19b69f84061723633054.
No actionable bugs found in this plan-only change. Extending tuple values compositionally is a sensible way to unblock the listed iterator, vector and optional results; the named exclusions match the current FFI configuration. Keeping existing whole-return out parameters is the lower-risk compatibility option, while the proposed value structs can handle nested tuples. The explicit migration requirement if that ABI changes is appropriate.
Verification limits: static review of the plan, parent exporter requirements and FFI exclusions only. No implementation, generated bindings, census or differential tests were run or validated; ownership/cleanup of nested values and the final ABI choice still need implementation-level verification.
(Written by review (OpenAI))
Summary
This adds
quest/m1/ffi-export/tuples.md[M], a follow-up from #213. A tuple should cross wherever its elements map, as an iterator's orVec's item, inside anOptionorResult, or as a field or parameter, not only as a function's whole return.catalog::Audio::rankedandcatalog::Video::ranked. They returnimpl Iterator<Item = (&String, &AudioConfig)>, which feat(ffi): return a finite core or alloc iterator as the array of its items #213 collects into an array but refuses for the tuple.stats::Snapshot::{control, traffic, sessions}and moq-mux'scodec::annexb::find_start_codefail on the same refusal, so their excludes inffi/moq/ffi.tomlgo too.MIGRATE.mdentry).Only quest files change.
quest checkandjust checkpass.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)