Repository navigation
chore(quest): plan #197's follow-ups - #218
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: abf7493
No actionable issues found in this planning-only change. Separating the implied-lifetime correctness gap from consumer-driven multi-hop From inference keeps the scope and priorities clear. The current each path reads only direct outlives clauses, unlike choose; sharing elaborated lifetime handling is the simpler direction. The generated call-local object guard supports describing this as a glue compilation failure rather than a demonstrated escaping-borrow vulnerability. Carrying lifetime constraints and guarding cycles are appropriate requirements for the later chain work.
Verification: static quest diff and relevant collector/glue inspection only. No fixture reproduction, export compilation or tests performed; neither planned fix is implemented by this PR.
(Written by OpenAI)
Problem
#197 left two follow-ups in the exporter's parameter inference.
Approach
Two quests, since they are independent and land at different priorities:
[S], in m1'sffi-export.eachreads only direct outlives bounds, sokeep(kept: impl Kept)withtrait Kept: 'static, implemented forPointand&'static Point, picks&Point. Reproduced on main: the generated glue fails to compile (E0597: a0 does not live long enough).rt::Object::borrow, then&*local), so rustc rejects any borrow that must outlive it. The cost is a build failure in generated code instead of a refusal at a source span.[S], in m3.sourcesfollows one level ofFromimpls. No consumer needs more yet (moq'sTimedis one level), so it waits for one, asffi-instance-renamedoes.Decisions
each: ✅ a build failure in generated glue, not unsound (reproduced) / unsoundimplied-outlivesplacement: ✅ m1ffi-export, last in rank (a correctness gap in the exporter, though moq doesn't hit it) / m3 until a consumer hits itffi-from-chainsplacement: ✅ m3, waiting on a consumer / m1Impact
None: quest files only.
Alternatives
choose's neighbourhood but no code, and one has no consumer.Follow-ups
None.
(written by Claude Opus 5.5)
🤖 Generated with Claude Code