Repository navigation
fix(ffi): call #188's inferred instances from the Kotlin test - #194
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
kixelated
left a comment
There was a problem hiding this comment.
Automated review by review (OpenAI)
Reviewed commit: b851870.
No actionable bugs found. The four added calls in ffi/tests/api.kt:242–246 match the native transcript and C++ fixture in arguments, callback behavior, and output order. Restoring Kotlin coverage in the existing transcript comparison is the appropriate minimal fix; no production changes or additional abstraction are needed.
Verification: static inspection of the diff, Kotlin/C++ fixtures, native transcript, and Kotlin transcript-comparison harness. I did not run the tests; the locally passing command is the author's report, not independent verification.
Problem
just ffi testfails on main: the Kotlin transcript differs from the native one. #188 addedapply,report,wrapped, andkeepsto the api fixture, its native transcript, and the C and C++ tests. #184's Kotlin test was written before them, and each PR passed alone.Approach
Add the same four calls to
ffi/tests/api.kt, mirroringapi.cpp.just ffi test --test fixtures apipasses locally.Impact
Alternatives
None.
Follow-ups
None. Main's CI doesn't run on direct merges, so a combined break like this one shows up only on the next PR's run until the land queue is set up.
🤖 Generated with Claude Code
(written by Claude Opus 5.5)