Skip to content

fix(ffi): call #188's inferred instances from the Kotlin test - #194

Merged
kixelated merged 1 commit into
mainfrom
fix/kotlin-inferred-instances
Oct 28, 2026
Merged

kixelated merged 1 commit into
mainfrom
fix/kotlin-inferred-instances

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Problem

just ffi test fails on main: the Kotlin transcript differs from the native one. #188 added apply, report, wrapped, and keeps to the api fixture, its native transcript, and the C and C++ tests. #184's Kotlin test was written before them, and each PR passed alone.

Approach

Add the same four calls to ffi/tests/api.kt, mirroring api.cpp. just ffi test --test fixtures api passes locally.

Impact

  • None: test only.

Alternatives

None.

Follow-ups

None. Main's CI doesn't run on direct merges, so a combined break like this one shows up only on the next PR's run until the land queue is set up.

🤖 Generated with Claude Code

(written by Claude Opus 5.5)

#184 and #188 merged apart: #188 added apply, report, wrapped, and keeps to
the api fixture's native transcript and its C and C++ tests, while #184's
Kotlin test predates them, so `just ffi test` fails on main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T22:36:58.486698Z b851870 PR opened
🔒 Security Review ✅ Completed 2026-10-28T22:37:44.043950Z b851870 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)

Reviewed commit: b851870.

No actionable bugs found. The four added calls in ffi/tests/api.kt:242–246 match the native transcript and C++ fixture in arguments, callback behavior, and output order. Restoring Kotlin coverage in the existing transcript comparison is the appropriate minimal fix; no production changes or additional abstraction are needed.

Verification: static inspection of the diff, Kotlin/C++ fixtures, native transcript, and Kotlin transcript-comparison harness. I did not run the tests; the locally passing command is the author's report, not independent verification.

@kixelated
kixelated merged commit 326203c into main Oct 28, 2026
1 check passed
@kixelated
kixelated deleted the fix/kotlin-inferred-instances branch October 28, 2026 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant