Skip to content

chore(quest): follow-ups from #87 through #99 - #102

Merged
kixelated merged 6 commits into
mainfrom
quest/followups-cmp-generic
Oct 27, 2026
Merged

kixelated merged 6 commits into
mainfrom
quest/followups-cmp-generic

Conversation

@kixelated

@kixelated kixelated commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Follow-up quests the maintainer chose from the #87, #94, #96, #97, #98, and #99 reports:

  • quest/m2/ts-cmp-defaults.md: the default ne/lt/le/gt/ge a crate's own impls inherit, plus [u8] equality (about 60 moq-net ne refusals).
  • quest/m2/ts-cow-str.md: Cow<str> (139 moq-net refusals, the last one in ietf/namespace.rs).
  • quest/m2/ts-str-slice.md: &s[a..b] and &str patterns, so rfind's byte offsets are usable.
  • quest/m2/ts-shared-read.md, rewritten: share a Copy aggregate when nothing in the crate writes into that type in place, which removes fix(ts): copy Copy aggregates by type #83's self.form copy, fix(ts): copy what a container stores #99's copy$Form, and map-key copies, in place of the narrow held-back-read fix.
  • quest/m2/ts-bench-aa.md: the bench's A/A measures only noise, in JSC and Firefox too.
  • quest/m1/ffi-generic.md: export a generic type at the instances the config names (about 67 partly covered moq-ffi items).

Consumer: moq, through the translator's census and the exporter's coverage of moq-ffi.

Public API: none.

(written by Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn

Follow-ups from #98 and #94.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-27T03:15:40.128106Z a89d428 New commits
🔒 Security Review ✅ Completed 2026-10-27T03:17:40.390095Z a89d428 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 50e2c59

No actionable bugs found in these two follow-up plans. The comparison quest correctly distinguishes inherited defaults from overrides and derives ordering from partial_cmp, including unordered results, rather than incorrectly combining equality and ordering. Explicitly named generic instances with checked C names and refusal of unconfigured instances are a suitably bounded alternative to automatic ABI expansion; preserve the existing cross-export name-collision checks when implementing this.

Verified the scope against #94/#98 and the exporter’s current configuration/ABI rules. Plan/source inspection only; no implementation, tests, or census runs were executed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@kixelated kixelated changed the title chore(quest): default comparison methods and generic instances chore(quest): follow-ups from #94, #96, and #98 Oct 27, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 3999100

Reviewed the two new quests since 50e2c59; no actionable bugs found in the plans. The earlier comparison/generic-instance plans are unchanged. Separating Cow<str> from UTF-8 slicing/pattern support follows #96’s actual refusal boundaries and keeps the work bounded.

For implementation, a plain JS string is sufficient only while ownership-variant observations remain explicitly refused; supporting matches!/is_borrowed requires the tagged alternative already identified. Keep empty-pattern progress/endpoint behavior and byte-boundary failures in the planned native differential coverage rather than delegating to JS slicing/splitting semantics.

Plan/source inspection against #96 only; no implementation, tests, or census runs executed.

kixelated and others added 2 commits October 26, 2026 19:48
Replaces ts-shared-read's narrow fix, as #99 suggested.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@kixelated kixelated changed the title chore(quest): follow-ups from #94, #96, and #98 chore(quest): follow-ups from #94, #96, #98, and #99 Oct 27, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: 2aa91ca

Reviewed the replacement of the narrow held-read optimization with whole-crate immutable-type sharing since 3999100, excluding the merged main changes. No actionable bugs found in the plan; the other quests are unchanged.

The broader analysis can remove several redundant copies through one rule rather than special-casing the decoder. Its stated fail-closed boundary is essential: include nested field/element and discriminant mutations, and keep copies where mutation can escape the analyzed crate. The planned cross-module/generic cases plus #83/#99 aliasing regressions are appropriate; retained Rust value semantics matter more than reaching the pre-fix timing target.

Plan/source inspection only, including #99’s store-analysis rationale. No tests, census runs, or benchmarks executed.

kixelated and others added 2 commits October 26, 2026 20:15
@kixelated kixelated changed the title chore(quest): follow-ups from #94, #96, #98, and #99 chore(quest): follow-ups from #87 through #99 Oct 27, 2026

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: a89d428

Reviewed the new A/A benchmark-control quest since 2aa91ca, excluding upstream #96/#99 changes. No actionable bugs found in the plan; earlier quests are unchanged. Matching module layout and isolating routes directly addresses the reported profile-sharing/layout confounders instead of treating their systematic difference as timing noise.

For implementation, a separate process is the clearer isolation baseline; a realm-based alternative should demonstrate that the engine does not still share the relevant compiled-code/type profiles. Preserve comparable warm-up and randomized/repeated route scheduling so isolation does not simply replace cross-route contamination with run-order drift.

Plan/source inspection against the benchmark harness and #97’s report only; no benchmark measurements or tests run, and the reported engine effects were not independently reproduced.

@kixelated
kixelated merged commit 80f4487 into main Oct 27, 2026
1 check passed
@kixelated
kixelated deleted the quest/followups-cmp-generic branch October 27, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant