fix(tree-compare): default Base to the older revision by felipebergamin · Pull Request #2139 · kernelci/dashboard

felipebergamin · 2026-09-25T18:20:12Z

What it is

Tree compare treated A as "from" and B as "to", but defaulted A to the branch head and B to the previous revision. A failure on the newest checkout was therefore labelled fixed instead of a regression.

Defaults are now chronological. Base is the previous revision and Compare is the current or latest checkout. Opening compare from tree details pre-fills the viewed commit as Compare and the page fills Base with the revision before it. The selector, tables, grouped tests table, and details drawer say Base and Compare instead of Side A and Side B, matching GitHub's naming.

The URL now carries one git-style param, range=<base>..<compare>, instead of hashA and hashB. Either side may be empty; the page fills the missing side and rewrites the URL once both are known. Once both hashes are set they are not reordered by timestamp. Only the swap button exchanges them. Change types (regression, fixed, and so on) follow Base to Compare. The API request params (hash_a, hash_b) are unchanged.

Closes #2130

How to test

Open the tree listing with a wide window (/tree?i=300), pick a tree's latest checkout, and click "Compare revisions". The URL should read compare?range=..<hash> and then change to range=<previous>..<hash> once commits load.
Confirm Compare is the current head and Base is the previous revision. A PASS to FAIL from previous to head shows as a regression.
Change Base and Compare in the dropdowns, including a newer Base and an older Compare. Reload. The order stays as selected and the summary and row change types follow Base to Compare.
Click swap. The range in the URL, the columns, and the change types invert together.
Use "Previous commit" and "Branch head" on one card. Only that side of the range changes.
Optional: open compare from the oldest commit in the history graph. Base may stay empty (known, non-critical; the listing and latest-checkout path is unaffected).

Visual reference

alanpeixinho · 2026-09-30T20:40:48Z

            <SortableHead
              className="text-center"
-              intlKey="treeCompare.sideB"
+              intlKey="treeCompare.target"


since we are renaming from sideA/sideB, I believe we could use nomenclature closer to what github does with base/compare, instead of base/target

Also, if we are already changing nomenclature, might be worth to change url params as well.
I would go with the proposal from @mentonin of using two dots ...

Those comments are not blockers. But suggestions.

@alanpeixinho I agree with the changes to the URL params. But I changed only on frontend, I'm afraid that changing the API params now can break other API consumers (I don't know if someone is already consuming the comparison api)

also renamed Target to Compare

felipebergamin · 2026-10-02T19:52:26Z

@alanpeixinho requesting a new review because I changed the URL params and renamed the Base/Target to Base/Compare.

Also requesting review from @tales-aparecida

alanpeixinho

Looks great

alanpeixinho · 2026-10-05T19:46:04Z

 }

-/** Mirror backend _CHANGE_COUNT_SELECT categories for A→B transitions. */
+/** Mirror backend _CHANGE_COUNT_SELECT categories for base→target transitions. */


change base -> compare

alanpeixinho · 2026-10-05T19:49:31Z

          )}
        >
-          {side}
+          {side === 'base' ? 'B' : 'C'}


nit: Do we still need those labels? They were more important when we named sides A and B

The compare page defaulted side A to the branch head and side B to the previous revision, while deriveCompareChange reads A as the 'from' side. A test that started failing on the newest revision was therefore classified as 'fixed' instead of a regression. Default side B to the branch head and side A to the revision before it, and pre-fill the current revision as side B when opening compare from Tree Details, so the default A -> B direction is oldest -> newest. Closes kernelci#2130

Side A/B hid the comparison direction. Use Base (from) and Target (to) in the selector, tables, and drawer; URL params stay hashA/hashB.

Replace the hashA/hashB search params with a single git-style `range` param, `<base>..<compare>`, so the URL reads the same way the page is labelled. Either side may be empty; the page still fills the missing side (compare defaults to the branch head, base to the revision before it) and rewrites the URL once both are known. The API request params (hash_a/hash_b) are unchanged. Part of kernelci#2130 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi> Co-authored-by: Cursor <cursoragent@cursor.com>

Main's grouped tests table and tree-compare kci-dev button still referenced the old side names after the Base/Compare rename, so the frontend typecheck failed on the merge with main. Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi> Co-authored-by: Cursor <cursoragent@cursor.com>

felipebergamin requested a review from alanpeixinho September 25, 2026 18:20

felipebergamin marked this pull request as ready for review September 25, 2026 18:24

alanpeixinho approved these changes Sep 30, 2026

View reviewed changes

felipebergamin force-pushed the fix/2130/swap-default-compare-revisions branch from 2f6dc14 to ae9a94a Compare October 2, 2026 19:47

felipebergamin requested review from alanpeixinho and tales-aparecida October 2, 2026 19:52

tales-aparecida approved these changes Oct 5, 2026

View reviewed changes

alanpeixinho approved these changes Oct 5, 2026

View reviewed changes

felipebergamin and others added 4 commits October 5, 2026 19:04

fix(tree-compare): label revisions as Base and Target

5505d22

Side A/B hid the comparison direction. Use Base (from) and Target (to) in the selector, tables, and drawer; URL params stay hashA/hashB.

felipebergamin force-pushed the fix/2130/swap-default-compare-revisions branch from 6ce3a54 to e6b3ab7 Compare October 5, 2026 22:04

felipebergamin added this pull request to the merge queue Oct 5, 2026

Merged via the queue into kernelci:main with commit d1d04f2 Oct 5, 2026
7 checks passed

Navigation Menu

Repository navigation

fix(tree-compare): default Base to the older revision - #2139

fix(tree-compare): default Base to the older revision#2139
felipebergamin merged 4 commits into
kernelci:mainfrom
profusion:fix/2130/swap-default-compare-revisions

felipebergamin commented Sep 25, 2026 •

edited

Loading

Uh oh!

alanpeixinho Sep 30, 2026

Uh oh!

alanpeixinho Sep 30, 2026

Uh oh!

alanpeixinho Sep 30, 2026

Uh oh!

felipebergamin Oct 2, 2026

Uh oh!

felipebergamin commented Oct 2, 2026

Uh oh!

alanpeixinho left a comment

Uh oh!

alanpeixinho Oct 5, 2026

Uh oh!

alanpeixinho Oct 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

felipebergamin commented Sep 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What it is

How to test

Visual reference

Uh oh!

alanpeixinho Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

alanpeixinho Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

alanpeixinho Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

felipebergamin Oct 2, 2026

Choose a reason for hiding this comment

Uh oh!

felipebergamin commented Oct 2, 2026

Uh oh!

alanpeixinho left a comment

Choose a reason for hiding this comment

Uh oh!

alanpeixinho Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

alanpeixinho Oct 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

felipebergamin commented Sep 25, 2026 •

edited

Loading