Repository navigation
charts: stop OTLP push when no endpoint is set - #166
Open
pennycoders wants to merge 1 commit into
Open
pennycoders wants to merge 1 commit into
pennycoders wants to merge 1 commit into
Conversation
Fixes kagent-dev#76 Signed-off-by: Alex P <dtk077@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the default values (no
otel.endpoint), ate-api-server, atelet, ate-controller and k8s-credential-provider push traces and metrics to the SDK default,localhost:4317, and log a connection error about once a minute.OTEL_<SIGNAL>_EXPORTERlike a disabled one. Metrics getprometheusrather thannone: it stops the push but keeps every scraped endpoint, whilenonewould also close atecontroller's:8080.substrate.otel.envlike the other components. It had noenv, so no value could configure or stop its export.substrate-atelet.values.yamlno longer say the Go components ignoreotel.traces.enabled; serverboot honorsOTEL_TRACES_EXPORTER.With
otel.endpointset, the rendered env of the existing components is unchanged; only the credential provider gains its env.Tested:
helm linton the four charts,hack/render-manifests.sh --check,helm unittest charts/substrate(three new cases, which fail without the template change),hack/verify-all.sh, andgo testfor the packages that render the chart.Fixes #76
AI use: AI-assisted, I reviewed and tested it.