Repository navigation
[release-2.0] Make network transport errors retryable - #981
Merged
Merged
Conversation
errors.IsRetryable only checks the HTTP status codes to determine if a retry is appropriate. We should consider transport errors, such as timeouts and connection refused issues to also be retryable, as they might disappear without configuration changes. As per Go documentation [1], any net/http method (which gophercloud uses) should return url.Error when a transport error occurs. This provides a Timeout() and Temporary() method [2] which we can use to determine, if the operation can be reasonably retried. Additionally, we check for some syscall errors such as ECONNREFUSED and ECONNRESET, and some io errors explicitly and retry on them aswell. [1] https://pkg.go.dev/net/http#Client.Do [2] https://pkg.go.dev/net/url#Error On-behalf-of: SAP nils.gondermann@sap.com Fixes #879
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport: #913
errors.IsRetryable only checks the HTTP status codes to determine if a retry is appropriate.
We should consider transport errors, such as timeouts and connection refused issues to also be retryable, as they might disappear without configuration changes.
As per Go documentation [1], any net/http method (which gophercloud uses) should return url.Error when a transport error occurs. This provides a Timeout() and Temporary() method [2] which we can use to determine, if the operation can be reasonably retried. Additionally, we check for some syscall errors such as ECONNREFUSED and ECONNRESET explicitly and retry on them aswell.
[1] https://pkg.go.dev/net/http#Client.Do
[2] https://pkg.go.dev/net/url#Error
Fixes #879