Repository navigation
fix(software-live): play audio far from its video on the video's axis - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A live MPEG-TS source whose audio runs more than a minute from its video could not play on the software path with a rewind buffer: FFmpeg's 33-bit wrap correction puts the audio about 26.5 h ahead, the audio sets the live edge, and the rewind buffer discards every video keyframe as older than its window.
What changed
LiveAudioAxis: audio more than 30 s from the video moves onto the video's axis, aligned on arrival, in both live loops (rewind and no rewind).Test plan
LiveAudioAxisTests.aetherctl play --live --sw --dvr-window 600on a local real-time stream with audio 274 s behind video, a Mac, macOS 27: stock 7.56.0 logs 15 eviction recoveries and 15 underruns in 30 s with the clock stopped; with this change none, 50 fps, clock running.LAN peers cannot take the slots kept for loopback, which times out the same way on stock 7.56.0.