Repository navigation
fix(software-live): fold short forward holes out of the live timeline - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Only timestamp jumps of 10 s or more were folded out of the software path's live timeline. A shorter hole, which a feed that pauses and skips what it missed leaves behind, played out as a standing picture with the clock running and the phase reading playing.
What changed
LiveHoleFold: on the rewind route, a forward hole of 3 s or more in both streams folds. Audio decides what is a hole, so a sparse picture over continuous sound stays as stamped.Test plan
LiveHoleFoldTests.aetherctl play --live --sw --dvr-window 600on a local real-time stream that pauses 8 s and skips what it missed, a Mac, macOS 27: stock 7.56.0 stops twice; with this change once, the second stop gone.LAN peers cannot take the slots kept for loopback, which times out the same way on stock 7.56.0.