Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,9 @@ warn_unused_configs = true
warn_unused_ignores = true

[tool.pylint.MASTER]
extension-pkg-allow-list = [
"orjson",
]
ignore = [
"tests",
]
Expand Down
9 changes: 9 additions & 0 deletions src/python_overseerr/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,12 @@ class OverseerrConnectionError(OverseerrError):

class OverseerrAuthenticationError(OverseerrError):
"""Overseerr authentication exception."""


class OverseerrNothingToRequestError(OverseerrError):
"""Raised when there is nothing left to request.

Overseerr responds with HTTP 202 and a ``{"status", "message"}`` body
instead of a created request when every requested season is already
requested or available (``NoSeasonsAvailableError`` server-side).
"""
13 changes: 11 additions & 2 deletions src/python_overseerr/overseerr.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,14 @@

from aiohttp import ClientError, ClientResponseError, ClientSession
from aiohttp.hdrs import METH_DELETE, METH_GET, METH_POST, METH_PUT
import orjson
from yarl import URL

from .exceptions import OverseerrAuthenticationError, OverseerrConnectionError
from .exceptions import (
OverseerrAuthenticationError,
OverseerrConnectionError,
OverseerrNothingToRequestError,
)
from .models import (
Issue,
IssueCount,
Expand Down Expand Up @@ -171,7 +176,11 @@ async def create_request(
if seasons:
data["seasons"] = seasons
response = await self._request(METH_POST, "request", data=data)
return RequestWithMedia.from_json(response)
parsed: dict[str, Any] = orjson.loads(response)
if parsed.get("status") == 202:
msg = parsed.get("message", "No request was created")
raise OverseerrNothingToRequestError(msg)
return RequestWithMedia.from_dict(parsed)

async def get_issues(
self,
Expand Down
4 changes: 4 additions & 0 deletions tests/fixtures/overseerr/no_seasons_available.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"status": 202,
"message": "No seasons available to request"
}
4 changes: 4 additions & 0 deletions tests/fixtures/seerr/no_seasons_available.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"status": 202,
"message": "No seasons available to request"
}
21 changes: 21 additions & 0 deletions tests/test_overseerr.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
OverseerrAuthenticationError,
OverseerrConnectionError,
OverseerrError,
OverseerrNothingToRequestError,
)
from python_overseerr.models import (
IssueStatus,
Expand Down Expand Up @@ -514,6 +515,26 @@ async def test_creating_request(
)


@pytest.mark.parametrize("service", SERVICES)
async def test_creating_request_nothing_to_request(
responses: aiointercept,
client: OverseerrClient,
service: str,
) -> None:
"""Test creating a request when every season is already requested or available.

Overseerr responds with HTTP 202 and a {"status", "message"} body
instead of a created request in this case, rather than an HTTP error.
"""
responses.post(
f"{MOCK_URL}/request",
status=202,
body=load_fixture(f"{service}/no_seasons_available.json"),
)
with pytest.raises(OverseerrNothingToRequestError):
await client.create_request(MediaType.TV, 249522, "all")


@pytest.mark.parametrize("service", SERVICES)
async def test_fetching_single_issue(
responses: aiointercept,
Expand Down
Loading