Skip to content

fix: load the native library once per JVM when NativeBase is reloaded #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msafonov merged 1 commit into from
Oct 11, 2026
Merged

fix: load the native library once per JVM when NativeBase is reloaded #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions spark/src/main/java/org/apache/comet/NativeBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ public abstract class NativeBase {

private static final String libraryToLoad = System.mapLibraryName(NATIVE_LIB_NAME);
private static boolean loaded = false;
private static boolean libraryLoaded = false;
private static volatile Throwable loadErr = null;
private static final String searchPattern = "libcomet-";
private static final AtomicBoolean released = new AtomicBoolean(false);
Expand Down Expand Up @@ -91,13 +92,18 @@ static synchronized void load() {
return;
}

// Try to load Comet library from the java.library.path.
try {
System.loadLibrary(NATIVE_LIB_NAME);
if (libraryLoaded) {
loaded = true;
} catch (UnsatisfiedLinkError ex) {
// Doesn't exist, so proceed to loading bundled library.
bundleLoadLibrary();
} else {
// Try to load Comet library from the java.library.path.
try {
System.loadLibrary(NATIVE_LIB_NAME);
loaded = true;
} catch (UnsatisfiedLinkError ex) {
// Doesn't exist, so proceed to loading bundled library.
bundleLoadLibrary();
}
libraryLoaded = loaded;
}

initWithLogConf();
Expand Down
Loading