Repository navigation
Conversation
- Removed the existing test file for msbuild-runner. - Introduced multiple scripts for GitHub Actions to manage releases, tags, and npm publishing. - Implemented a new MSBuild command builder and runner to streamline the build process. - Added architecture service to determine the platform and architecture. - Created a comprehensive TypeScript setup with strict type checking and module resolution. - Enhanced error handling and logging for MSBuild tasks. - Updated package structure to support new features and improve maintainability.
- Implement tests for MSBuildCommandBuilder to validate command construction with various options. - Create tests for MSBuildFinder to ensure correct version detection and path handling. - Add tests for MSBuildOptions to verify default and custom option handling. - Develop tests for MSBuildRunner to check process spawning and error handling.
chore: Add unit tests for MSBuild components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major overhaul of the project's configuration, CI/CD workflows, and codebase. It removes legacy configuration files, adds a modern GitHub Actions-based build and release pipeline, and introduces several utility scripts to automate versioning, coverage checks, and release management. Additionally, it removes the main plugin implementation and its constants, indicating a significant refactor or migration of core logic.
Key changes include:
CI/CD Pipeline Modernization:
.github/workflows/build.yml,.github/workflows/main.yml.disabled) to handle building, testing, coverage checking, versioning, releasing, and rollback, replacing the old Travis CI setup. [1] [2] [3].github/scripts/for tasks such as PR title verification, tag management, coverage enforcement, NPM publishing, and release rollback. [1] [2] [3] [4] [5] [6] [7] [8] [9]Codebase Cleanup and Refactor:
index.js) and its constants (lib/constants.js), suggesting a significant refactor, possible migration, or deprecation of the existing codebase. [1] [2]Configuration and Documentation Updates:
.editorconfig,.gitattributes,.travis.yml,.zarro-defaults, and updated.npmignoreto ensure thedist/folder is included in published packages. [1] [2] [3] [4] [5]README.mdto clarify the default and possible values for thetoolsVersionoption, reflecting support for newer MSBuild versions and improved auto-detection logic.Linting and Style Adjustments:
.jshintrcconfiguration by adjusting ECMAScript version and removing unused options. [1] [2]These changes collectively modernize the project's development and release process, clean up unused or legacy code, and improve documentation for users and contributors.