Skip to content

fix: shellcheck-clean scripts and correct Catalyst OpenSSL path - #85

Open
kochj23 wants to merge 1 commit into
jasonacox:masterfrom
kochj23:claude/shellcheck-catalyst-path
Open

kochj23 wants to merge 1 commit into
jasonacox:masterfrom
kochj23:claude/shellcheck-catalyst-path

Conversation

@kochj23

@kochj23 kochj23 commented Nov 7, 2026

Copy link
Copy Markdown
  • libcurl Catalyst build pointed at openssl/catalyst while the OpenSSL
    build writes openssl/Catalyst; fails on case-sensitive volumes
  • 'wihte' typo left ${white} unset in the color palette
  • quoted globs in 'rm -rf "/tmp/${VER}-*"' never matched, leaving stale
    logs that the error trap then tails
  • 'sed -ie' on macOS created a stray '15-ios.confe' backup file
  • ${iOS_SDK_VERSION} typo in OpenSSL phase2 simulator message
  • drop no-op 'export $PLATFORM' lines and dead variables
  • add 'cd ... || exit' guards
  • add tests/test_lint.sh and a CI lint job

Testing

Ran the new test script for this change plus bash -n on every script on macOS (Apple silicon).

Result on this branch: (test_lint.sh:ok; bash -n all scripts). The new tests fail on master and pass with the change.

🤖 Generated with Claude Code

- libcurl Catalyst build pointed at openssl/catalyst while the OpenSSL
  build writes openssl/Catalyst; fails on case-sensitive volumes
- 'wihte' typo left ${white} unset in the color palette
- quoted globs in 'rm -rf "/tmp/${VER}-*"' never matched, leaving stale
  logs that the error trap then tails
- 'sed -ie' on macOS created a stray '15-ios.confe' backup file
- ${iOS_SDK_VERSION} typo in OpenSSL phase2 simulator message
- drop no-op 'export $PLATFORM' lines and dead variables
- add 'cd ... || exit' guards
- add tests/test_lint.sh and a CI lint job

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant