Repository navigation
Conversation
curl -LOs without --fail saves the HTTP 404 page as <pkg>.tar.gz and returns 0. tar then fails, and every later run prints 'Using <pkg>.tar.gz' and fails again because the bogus file is cached. Use --fail, remove any partial file, and print a clear error for curl, nghttp2 and both OpenSSL phases. Adds tests/test_download.sh (offline, stubbed curl) as a regression test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
curl -LOs without --fail saves the HTTP 404 page as .tar.gz and
returns 0. tar then fails, and every later run prints 'Using .tar.gz'
and fails again because the bogus file is cached. Use --fail, remove any
partial file, and print a clear error for curl, nghttp2 and both OpenSSL
phases.
Adds tests/test_download.sh (offline, stubbed curl) as a regression test.
Testing
Ran the new test script for this change plus
bash -non every script on macOS (Apple silicon).Result on this branch: (test_download.sh:ok; bash -n all scripts). The new tests fail on
masterand pass with the change.🤖 Generated with Claude Code