Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path.removedirs_p()documents that missing directories are tolerated, but currently raisesFileNotFoundErrorfor an absent directory or parent. This adds that exception to the existing suppression, so repeated cleanup of an already removed tree is harmless.Regression coverage includes a missing leaf, a missing parent, repeated removal, and an existing file that must still raise. The three missing-directory cases fail on the original code; all functional tests and doctests pass afterward (140 passed, 7 platform skips), with 100% coverage of the changed source line. Formatting, documentation build/lint, wheel/sdist build, and
twine checkpass on Python 3.12/Windows.The full pytest check configuration still reports seven Ruff file checks and one mypy unused-ignore failure. I ran the same checks on the original source and verified the complete static-diagnostic sequence is unchanged; these failures predate this patch.