Repository navigation
feat(agent): llmOptions.vendorParams type; catch up with schema 0.4.29 - #22
Merged
Merged
Conversation
@jambonz/schema ^0.4.26 -> ^0.4.29. Adds AgentLlmOptions.vendorParams and the deprecated reasoningEffort, and Recognizer.giggyOptions, which the drift test flagged after the bump. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jambonz/schema^0.4.26 → ^0.4.29, and the type changes that need:AgentLlmOptions.vendorParams(Record<string, unknown>), from feat(agent): add llm.llmOptions.vendorParams passthrough schema#66. Without it, writingvendorParamsinline insession.agent({...})is a TypeScript error (TS2353), so TS users can't use the feature without a cast.AgentLlmOptions.reasoningEffort, marked@deprecated(chore(agent): deprecate llmOptions.reasoningEffort schema#67). It has no effect; the doc comment points tovendorParams. Typed so existing code keeps compiling, and editors strike it through.Recognizer.giggyOptions, from schema 0.4.27. The drift test failed on it after the bump.Verified
vitest: 131/131, including the schema drift test.npm run typecheckandbuildpass.session.agent({...})call usingvendorParams,reasoningEffortandgiggyOptionstypechecks with the project tsconfig. Before this change it fails with TS2353 onvendorParamsandgiggyOptions.eslintisn't a dependency of this package, sonpm run lintfails withcommand not found(pre-existing).Note: the drift test only compares top-level properties, so it never flagged
vendorParams(nested underllm.llmOptions). Nested drift will keep slipping through until the test recurses.🤖 Generated with Claude Code