Repository navigation
Conversation
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the dependency work used in the temporary Windows 2.5 compatibility build, separated from #203 so it can be reviewed on its own. The upstream package version stays at 0.5.31; there are no fork release files, game files or bundled binaries in this diff.
The manifest updates are:
The lockfile also refreshes compatible transitive dependencies. The pinned
hamt-syncandrust_sequence_trierevisions are unchanged. Older transitive copies of some crates remain; this is not a claim that every dependency is now the newest available version.The CLI changes adapt to bpaf 0.9 while preserving the existing engine argument combinations, including bare and explicit boolean profile options.
--helpnow exits successfully instead of being treated as a missing compile operation. Added user-hint TOML tests cover Unicode messages, file/source matching and malformed files.On this standalone branch, 6222 local tests passed, plus workspace build, all-target Clippy and stable formatting:
The first build regenerated workspace version entries in the lockfile after removing the fork's version bump. External dependency pins match the reviewed compatibility release.
I'm leaving this as a draft because the bindgen-based
scc-lib-testspath still needs a libclang-equipped environment. The updated compiler/DLL have independent Windows checks in the combined build, but those do not validate the new bindgen generation path or macOS/Linux. Stable rustfmt also does not check the nightly-only formatting options. No hosted CI was requested or run from this submission.The flexstr 0.11 migration is deferred because its ownership/borrowed-string API needs separate work. The optional non-Windows GTK path still has glib 0.15.12 (RUSTSEC-2024-0429) and unmaintained proc-macro-error 1.0.4 (RUSTSEC-2024-0370). These were not found in the reviewed Windows normal/build graph, but they remain unresolved for that optional path. No performance gain or all-platform security cleanup is claimed.
The complete combined source and Windows package are available in 0.5.31-cp25.2. The 2.5 format change (#203) and error-buffer fix (#204) can be reviewed independently.