Repository navigation
fix: support script bundles from game patch 2.5 - #202
Merged
Merged
Conversation
Since patch 2.5 the game sets header flag 0x2 and stores a 7th table header right after the regular 104-byte header (an extra table with one 12-byte record per definition). The sequential reader didn't skip it, so every table after the header was read 12 bytes early and loading failed with 'failed to fill whole buffer'. Skip the extra table header when the flag is set, and clear the flag when saving since the table isn't written back (matching redscript 1.0).
Author
|
Looks like the new table header has something to do with the new in-game mod support + reloading. |
Author
|
In-game official mod reload support works with this patch alone (+ some RED4ext work) so it's fine |
Contributor
|
LGTM, had to update modular-bitfield to Decompile ran clean, test scripts working |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slopped
Redscript on 2.5 seems to add some new table header that we don't really care about I guess? Not sure if le fix is correct but I can get ingame and nyancat works