Repository navigation
Fix: Capture the whole error message with netmiko_regexp - #3950
Merged
Merged
Conversation
The netmiko error regexp is updated for EOS, IOS, and IOS XR to capture the whole error message.
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The IOS regexp must be adjusted to capture the complete error line, including the leading % .
0 open findings
What changed in this PR
Updates Netmiko error regexps for EOS, IOS, and IOS XR, with documentation and an IOS testing topology.
Changes:
- Expands device-specific error matching.
- Adds IOS Netmiko test scenarios.
- Documents manual configuration testing.
| File | Description |
|---|---|
tests/config/README.md |
Documents manual Netmiko testing. |
tests/config/ios-netmiko.yml |
Adds IOS error-condition topology. |
netsim/devices/xr.yml |
Expands IOS XR error matching. |
netsim/devices/ios.yml |
Extends IOS error matching; leading % remains omitted. |
netsim/devices/eos.yml |
Expands EOS error matching. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The netmiko error regexp is updated for EOS, IOS, and IOS XR to capture the whole error message.