Repository navigation
test: Apply the withdrawals before the block-end system calls - #1755
Merged
Merged
Conversation
The withdrawals are processed after the transactions (EIP-4895) and the block-end system calls are made at the end of the block processing (EIP-7002, EIP-7251), so the withdrawals go first. The order is unobservable unless a system contract is modified, e.g. to read its balance.
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1755 +/- ##
=======================================
Coverage 98.07% 98.07%
=======================================
Files 183 183
Lines 16944 16944
Branches 3876 3876
=======================================
Hits 16618 16618
Misses 245 245
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the execution specification’s withdrawal-before-request ordering.
0 open findings
What changed in this PR
Moves block finalization so withdrawals are applied before block-end system calls, matching Ethereum processing order.
Changes:
- Finalize state before collecting requests.
- Update transition documentation.
| File | Description |
|---|---|
test/utils/block_transition.cpp |
Reorders finalization before block-end calls. |
test/utils/block_transition.hpp |
Documents the corrected order. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The withdrawals are processed after the transactions (EIP-4895) and the
block-end system calls are made at the end of the block processing
(EIP-7002, EIP-7251), so the withdrawals go first. The order is
unobservable unless a system contract is modified, e.g. to read its
balance.