Repository navigation
Visit exception subclasses once across inheritance diamonds - #93
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A multiply inherited exception subclass is traversed once for each path from BaseException. Global install therefore repeatedly registers the same class; deeper inheritance diamonds make traversal grow exponentially.
Remember visited classes during the existing iterative depth-first traversal. Two regressions fail before: unique traversal of a diamond and exactly one copyreg registration per exception class during global install. After: full Python 3.12 suite 65 pass; Python 3.10 63 pass with 2 ExceptionGroup version skips. Pinned Ruff 0.14.3 source/test lint and changed-file formatting pass. AUTHORS and changelog updated, final diff inspected. No new dependencies.
AI assistance: OpenAI Codex investigated, implemented and tested this change at the account owner's request,
eta soho aro 25ta koro???. No independent human review is claimed.