Repository navigation
Convert deep traceback dictionaries without recursion - #92
Open
ShahadatTest wants to merge 1 commit into
Open
ShahadatTest wants to merge 1 commit into
ShahadatTest wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Traceback.__init__already handles chains iteratively, butas_dict()andfrom_dict()still recurse once per frame. Converting a traceback deeper than the recursion limit raisesRecursionError, including when attempting to report an original recursion failure.Build the linked dictionary and intermediate traceback nodes iteratively.
from_dictconstructs the final Traceback only once, retaining the existing metadata and optional-local handling. Add deep-chain regressions, a changelog entry and contributor credit.Validation on Windows:
Checked current contribution instructions, all open PRs, and existing recursion reports. Earlier #16 fixes construction, not these dictionary conversions; no overlapping open fix was found.
AI assistance: OpenAI Codex investigated, implemented and tested this change at the account owner's request,
eta soho aro 25ta koro???. No independent human review is claimed.