Repository navigation
chore: schema pin 9 -> 15, extraction pin 26 -> 28, after verifying the queries (#124) - #125
Merged
Merged
Conversation
…he queries (#124) Every live index reads schema 15 / extraction 28, so select BLOCKED on all three registered repos and the pre-push hook answered nothing. Migrations 10-15 add indexes, a synthesis_inputs table and name_tail / metadata.synthesizedBy rewrites; schema.sql v9..HEAD changes no column. testgraph reads none of the rewritten fields and has no positional reads over SELECT *. All 15 read paths run clean against a live schema-15 index, and select answers OK on testgraph, honeyslate and signedintake. Refs #124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All three registries pinned schema 9 / extraction 26, while every codegraph index on this machine now reads 15 / 28. So testgraph answered BLOCKED on its own repo and on both dogfood targets, and the pre-push hook gave no answer on every push:
The pin exists to catch column semantics changing under testgraph's queries. Bumping the number without checking would defeat it, so this is what was checked, following #79.
1. Migrations 10–15 drop and rename nothing
From
codegraph src/db/migrations.ts, forkmain(CURRENT_SCHEMA_VERSION = 15):idx_nodes_kind; newsynthesis_inputstable; new partial index on edge metadata; setsmetadata.synthesizedByon cross-file Gocontainsedgesunresolved_refs; rewritesname_tailon failed refsunresolved_refsschema.sqlfrom v9 to HEAD adds indexes andsynthesis_inputsonly. No column was added, dropped, renamed or retyped.2. testgraph reads none of the rewritten data
$.confidenceand$.resolvedBy, plus theprovenancecolumn. Nothing readssynthesizedBy, and v10 only touchescontainsedges, which are not inREACH_KINDS.name_tail. Its only use ofunresolved_refsiscount(*) WHERE status = 'pending'.SELECT *intestgraph/orharness/. Everyr[n]indexes an explicit column list.3. Every read path run against the live schema-15 index
4. End to end on all three registered repos (
--base HEAD~5)Before the bump, all three were BLOCKED. The "extraction pin is behind" warning is gone too.
python3 -m unittest discover -s tests:Ran 477 tests ... OK.Not covered
#124's third item is still open: a check that fails when a registry pin lags the deployed codegraph. CI has no index and no codegraph binary to compare against, so it needs a design decision. This PR therefore says
Refs #124and does not close the issue.After merge, run
git -C ~/personal_projects/testgraph/main pull --ff-only. The pre-push hook reads that worktree's registries.