Repository navigation
fix(diff): never draw an import statement as a changed root - #48
Merged
Merged
Conversation
matchRootSymbols excluded file nodes but not import nodes, so a changed file's import statements became bold diff roots, and probing an import's text as a name can resolve to another symbol and draw its edges (the --architecture bug fixed in #46). Import nodes are now excluded too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #46/#47.
matchRootSymbolsexcluded"kind":"file"nodes but not"kind":"import"ones. So a changed file's import statements became bold--diffroots, and probing an import's text as a name (../src/mcp/tools) can resolve to another symbol and draw its callers/callees: the same fabrication #46 fixed for--architecture. Import nodes are now excluded too.Reproduced on a TS repo with a changed
test/t.ts: before, two roots (runTestand"../src/mcp/tools"); after, onlyrunTest. The regression test was written first and failed on the old code.Local:
node test/run.js192 passed, 0 failed (fork codegraph). TECHNICAL.md updated.