Repository navigation
Conversation
Contributor
|
This PR contains other commits that have not been committed. So cannot be approved without those being committed first or doing a rebase without being based on commits that are part of other PRs |
Unchecking a breakpoint in VS Code removed it from the TCF agent, and checking it again added it back with a new ID. The Breakpoints service has enable and disable commands for this, so use them and keep the breakpoint in the agent. DAP has no enabled flag. VS Code leaves a disabled breakpoint out of the next set*Breakpoints request, the same as a deleted one. The extension API still lists disabled breakpoints, so the adapter checks that list: breakpoints still in it are disabled, the others removed. VS Code does not show instruction breakpoints to extensions, so these are still removed when unchecked. Deactivating all breakpoints in VS Code now disables them in the agent, as VS Code still lists them. Signed-off-by: Claes Lillieskold <claes.lillieskold@intel.com>
clillies
force-pushed
the
bp-enable-disable
branch
from
November 9, 2026 13:54
a21faae to
03f4a7e
Compare
aragners
approved these changes
Nov 9, 2026
aragners
left a comment
aragners
left a comment
Contributor
There was a problem hiding this comment.
Tried it out with manual investigation of breakpoints and seems good. Looks better this way from TCF protocol perspective, although I guess not fully necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix disable/enable for breakpoints, dont delete and re-create.