Repository navigation
ci: Enable phpstan level 8 - #80
Merged
Merged
Conversation
acoulton
force-pushed
the
3.x-phpstan-l8
branch
from
October 27, 2026 13:44
d32f492 to
1252d97
Compare
acoulton
force-pushed
the
3.x-phpstan-l8
branch
from
October 27, 2026 14:47
1252d97 to
8ff5e24
Compare
Previously some did and some did not, causing confusion about whether the methods should be :string or :?string.
Theoretically the keypair could have been nulled at runtime e.g. if `__destruct` was called manually from userland code.
PHPStan couldn't follow this logic since we call an extra factory method .
acoulton
force-pushed
the
3.x-phpstan-l8
branch
from
October 27, 2026 14:59
8ff5e24 to
fad50e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.