Repository navigation
3.x: Fix PHPStan issues up to level 6 - #78
Merged
Merged
Conversation
acoulton
commented
Oct 26, 2026
Comment on lines
+35
to
36
| /** @var list<array-key>|null */ | ||
| protected ?array $expect_schema = null; |
Member
Author
There was a problem hiding this comment.
We'd kind-of expect the CSV to have string keys for the column headers, but arguably it could validly output numbered columns if the incoming array was a list / integer keys. So it's correct that actually this can be any array-key.
acoulton
force-pushed
the
3.x-phpstan-l6
branch
from
October 27, 2026 13:44
3b3ccf5 to
4261e8a
Compare
Add missing property, param and return types - both for actual things and for arrays etc.
These changes will affect runtime code.
These changes will only affect static analysis.
acoulton
force-pushed
the
3.x-phpstan-l6
branch
from
October 27, 2026 14:46
4261e8a to
28cd094
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of these were around loose array shapes, or missing method types in tests. There were however a few concrete types that were missing which I've included in a separate commit.
Several of these changes were fixed by Junie, I will give it a proper review.