Repository navigation
Conversation
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
2 times, most recently
from
September 30, 2026 12:59
1d15b28 to
0ca6d76
Compare
thoniTUB
changed the title
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
from
October 1, 2026 07:20
c9cb8f9 to
2847720
Compare
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
from
October 1, 2026 07:33
d9eb88e to
2b0d7a5
Compare
thoniTUB
marked this pull request as ready for review
October 1, 2026 07:33
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
from
October 1, 2026 08:24
2b0d7a5 to
0a677ab
Compare
awildturtok
reviewed
Oct 1, 2026
| @POST | ||
| @Consumes(MediaType.APPLICATION_JSON) | ||
| public Response addNewsItem(NewsItem newsItem, @Context UriInfo uriInfo) throws IOException { | ||
| if(newsItem == null) { |
Collaborator
Author
There was a problem hiding this comment.
Habe das ExceptionMapping zurück gedreht und nutze das bisherige nicht den RFC
| return Response.status(Response.Status.CREATED).entity(newsItem).build(); | ||
| } | ||
| catch(ConstraintViolationException exception) { | ||
| String detail = exception.getConstraintViolations().stream() |
Collaborator
There was a problem hiding this comment.
kannst du die validation nicht rausziehen? das hat bisschen was von Exception-Oriented-Programming :/
Collaborator
Author
There was a problem hiding this comment.
Ich habe die RFC 9457 anpassungen wieder rausgenommen
| @Delegate | ||
| private NewsService newsService; | ||
|
|
||
| public ManagedNewsService(NewsConfiguration configuration, Validator validator) { |
|
|
||
| private final NewsService newsService; | ||
| @PathParam(DATASET) | ||
| DatasetId datasetId; |
| item.link(), | ||
| item.date() | ||
| ) | ||
| ).toList(); |
Collaborator
There was a problem hiding this comment.
glaube du musst die nicht toListen?
Collaborator
Author
There was a problem hiding this comment.
Dann müsste ich einen Stream zurückgeben, der implizit zu einer Liste gemacht wird. Liste ist hier praktischer, da es dann später explizit auch zu einer OpenApi Spec gematched werden kann
| this.newsItemReader = om.readerFor(FileSystemNewsItem.class); | ||
| this.newsItemWriter = om.writerFor(FileSystemNewsItem.class); | ||
|
|
||
| Files.createDirectories(newsFolder); |
Collaborator
There was a problem hiding this comment.
knallt das wenn die schon existieren?
Collaborator
Author
There was a problem hiding this comment.
Nope, das ist wie mkdir -pr ...
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
2 times, most recently
from
October 7, 2026 10:22
aac0822 to
b2ae18e
Compare
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
from
October 13, 2026 12:08
b2ae18e to
937cf6b
Compare
Co-authored-by: Codex GPT-6 <codex@openai.com>
Co-authored-by: Codex gpt-6 <codex@openai.com>
thoniTUB
force-pushed
the
feat/integrate-news-service
branch
from
October 27, 2026 13:55
d185459 to
2987a05
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.