Repository navigation
test: add test tls/mtls - #721
Open
NguyenHoangSon96 wants to merge 2 commits into
Open
NguyenHoangSon96 wants to merge 2 commits into
NguyenHoangSon96 wants to merge 2 commits into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #721 +/- ##
==========================================
+ Coverage 90.49% 90.61% +0.11%
==========================================
Files 40 40
Lines 3568 3568
==========================================
+ Hits 3229 3233 +4
+ Misses 339 335 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NguyenHoangSon96
force-pushed
the
test/add-test-tls
branch
from
October 19, 2026 15:20
93710f1 to
29b6f0a
Compare
NguyenHoangSon96
force-pushed
the
test/add-test-tls
branch
2 times, most recently
from
October 21, 2026 06:41
fce50cd to
d41d2f9
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The regeneration script targets a developer-specific absolute path instead of the current checkout.
1 open issue
What changed in this PR
Expands InfluxDB client tests for TLS and mutual TLS authentication.
Changes:
- Adds successful and rejected certificate scenarios and SSL context precedence coverage.
- Adds certificate fixtures and a regeneration script.
- Improves test server cleanup and refreshes the shared server certificate.
| File | Description |
|---|---|
| tests/test_InfluxDBClient.py | Adds TLS/mTLS cases and server cleanup. |
| tests/test_data/certificates/other-server.pem | Untrusted certificate/key bundle. |
| tests/test_data/certificates/other-server.key | Untrusted identity's test key. |
| tests/test_data/certificates/other-server.crt | Untrusted certificate fixture. |
| tests/test_data/certificates/influxdb.pem | Server certificate/key bundle. |
| tests/test_data/certificates/influxdb.key | Server test key. |
| tests/test_data/certificates/influxdb.crt | Trusted server certificate. |
| tests/test_data/certificates/client.pem | Client certificate/key bundle. |
| tests/test_data/certificates/client.key | Client test key. |
| tests/test_data/certificates/client.crt | Trusted client certificate. |
| tests/server.pem | Refreshes shared server fixture. |
| scripts/generate-self-signed-cert.sh | Generates certificate fixtures. |
Review effort: Balanced
NguyenHoangSon96
force-pushed
the
test/add-test-tls
branch
from
October 21, 2026 07:59
9394b20 to
266438c
Compare
NguyenHoangSon96
marked this pull request as ready for review
October 21, 2026 09:36
NguyenHoangSon96
force-pushed
the
test/add-test-tls
branch
from
October 21, 2026 09:37
2dd4b17 to
a6f196b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #
Proposed Changes
Checklist
pytest testscompletes successfully