Repository navigation
Use the directory yaml to populate the broker vendor profiles at comp… - #815
Open
kurtnordstrom wants to merge 1 commit into
Open
kurtnordstrom wants to merge 1 commit into
kurtnordstrom wants to merge 1 commit into
Conversation
kurtnordstrom
marked this pull request as ready for review
October 12, 2026 21:45
kurtnordstrom
requested review from
JanisSaldabols,
adamdickmeiss,
jakub-id and
skomorokh
as code owners
October 12, 2026 21:45
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The source migration, build integration, validation, documentation, and regression coverage are consistent and complete.
0 open findings
What changed in this PR
Moves broker vendor profile defaults to a build-time generated table sourced from the Directory OpenAPI schema.
Changes:
- Adds and tests the profile generator.
- Integrates generation into Make and Docker builds.
- Removes obsolete embedded YAML profiles.
| File | Description |
|---|---|
directory/host-profiles.md |
Documents the new source and workflow. |
broker/profiles/cmd/genprofiles/main.go |
Implements profile generation and validation. |
broker/profiles/cmd/genprofiles/main_test.go |
Tests generation and invalid definitions. |
broker/profiles/builtin.go |
Removes runtime YAML embedding. |
broker/profiles/builtin_test.go |
Verifies generated defaults match the schema. |
broker/profiles/builtin/Alma.yaml |
Removes obsolete Alma defaults. |
broker/profiles/builtin/FOLIO.yaml |
Removes obsolete FOLIO defaults. |
broker/profiles/builtin/Generic.yaml |
Removes obsolete Generic defaults. |
broker/profiles/builtin/Koha.yaml |
Removes obsolete Koha defaults. |
broker/profiles/builtin/Sierra.yaml |
Removes obsolete Sierra defaults. |
broker/profiles/builtin/profile.schema.json |
Removes the obsolete profile schema. |
broker/Makefile |
Adds generation dependencies and cleanup. |
broker/Dockerfile |
Generates profiles during image builds. |
broker/Dockerfile.dockerignore |
Excludes locally generated profile output. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ile-time