Implement full-text index for entries, make name and description inde…

[kurtnordstrom]

…xes case insensitive

[Copilot]

🟡 Changes recommended

The migration permits mixed-version rollout failures and introduces a symbol/entry lock-order deadlock.

2 open findings

• Migration breaks rolling upgrades with pre-018 binaries · New
• Trigger introduces deadlocks through inconsistent lock ordering · New

What changed in this PR

Adds full-text directory entry search and case-insensitive name/description filtering.

Changes:

• Adds a trigger-maintained PostgreSQL search vector and GIN index.
• Adds cql.serverChoice and case-insensitive CQL fields.
• Documents and tests search, migration, update, and import behavior.

File	Description
directory/​api/​entries.go	Configures new CQL search behavior.
directory/​api/​entries_test.go	Tests CQL translation.
directory/​api.yaml	Documents the API search contract.
directory/​README.md	Documents search and deployment behavior.
directory/​migrations/​018_entry_search.up.sql	Adds the search vector, triggers, and indexes.
directory/​migrations/​018_entry_search.down.sql	Removes migration 018 objects.
directory/​import/​db/​repo_test.go	Adjusts import locking coverage.
directory/​test/​entry_search_test.go	Tests search indexing and concurrency.
directory/​test/​entry_search_migration_test.go	Tests migration lifecycle and backfill.
directory/​test/​entry_case_insensitive_test.go	Tests case-insensitive filtering.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🔵 Needs a closer look

The migration performs blocking index builds and an unbounded backfill during application startup, risking production write outages.

0 open findings

2 resolved since last review

• Trigger introduces deadlocks through inconsistent lock ordering
• Migration breaks rolling upgrades with pre-018 binaries

Previously missed (1)

In code that hasn't changed since last review

Non-concurrent symbols index build blocks live writes

directory/​migrations/​018_entry_search.up.sql:4

This regular index build takes a lock that blocks inserts, updates, and deletes on symbols, so live entry PATCH/import traffic can stall for the full scan. Build it with CREATE INDEX CONCURRENTLY in a dedicated non-transactional migration (and drop it concurrently on rollback where supported) to keep symbol writes available during rollout.

This issue also appears on line 85 of the same file.

🧠 Review effort: Balanced

[Copilot]

🟡 Changes recommended

Migration 018 can block all entry traffic during an ordinary application rollout.

1 open finding

• Migration holds table lock during backfill, causing production outage · New

🧠 Review effort: Balanced

[kurtnordstrom]

The complaints from copilot mainly center around a possible deadlock during database migration for currently running clients. However, since we are still in the pre-production phase and do not have clients to migrate, this should not be an issue.

[adamdickmeiss]

LGTM