Repository navigation
Fix races in ISO message confirmations - #808
Merged
Merged
Conversation
ISO HTTP handlers and asynchronous confirmation handlers accessed the shared waitingReqs map without synchronization. Notices were also published before their waiters were registered, allowing a fast confirmation to arrive before the HTTP request was ready to receive it. Protect all map access with a mutex, consume waiters through atomic lookup and removal, and register waiters before publishing notices. Remove waiters when publication fails. Add regression tests covering concurrent access, early confirmations, duplicate confirmations, and publication failure. Verified that the tests detect both original defects. Validation: focused race tests passed for 20 repetitions; ISO integration race tests, the full broker suite, lint, build, and all 135 Bruno requests passed.
adamdickmeiss
requested review from
JanisSaldabols and
jakub-id
as code owners
October 8, 2026 15:06
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The synchronization changes address the identified races and include focused regression coverage.
0 open findings
What changed in this PR
Fixes race conditions in ISO message confirmation handling.
Changes:
- Synchronizes waiter registration, lookup, and removal.
- Registers waiters before publishing confirmation notices.
- Adds regression coverage for concurrency, duplicate confirmations, and failures.
| File | Description |
|---|---|
broker/handler/iso18626-handler.go |
Adds synchronized confirmation waiter lifecycle. |
broker/handler/request_wait_test.go |
Tests concurrent and failure scenarios. |
broker/events/eventbus.go |
Supports caller-allocated notice IDs. |
broker/events/eventbus_test.go |
Verifies custom notice IDs. |
broker/patron_request/service/action_test.go |
Updates the event-bus mock. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
JanisSaldabols
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISO HTTP handlers and asynchronous confirmation handlers accessed the shared waitingReqs map without synchronization. Notices were also published before their waiters were registered, allowing a fast confirmation to arrive before the HTTP request was ready to receive it.
Protect all map access with a mutex, consume waiters through atomic lookup and removal, and register waiters before publishing notices. Remove waiters when publication fails.
Add regression tests covering concurrent access, early confirmations, duplicate confirmations, and publication failure. Verified that the tests detect both original defects.
Validation: focused race tests passed for 20 repetitions; ISO integration race tests, the full broker suite, lint, build, and all 135 Bruno requests passed.