Repository navigation
S13: require babyedwards on the point Point2Bits_Strict encodes - #155
Draft
OBrezhniev wants to merge 1 commit into
Draft
OBrezhniev wants to merge 1 commit into
OBrezhniev wants to merge 1 commit into
Conversation
OBrezhniev
force-pushed
the
fix/circomlib_buses_review
branch
from
September 29, 2026 18:39
b85175e to
7198ad7
Compare
OBrezhniev
force-pushed
the
fix/point2bits-requires-babyedwards
branch
from
September 29, 2026 18:39
580782c to
526ffae
Compare
Its contract is the encoding of a point of the curve, and its only
library caller, the EdDSA verifiers' hash output, already carries the
tag, but the input was an untagged Point, so the encoder accepted any
pair of field elements. Requiring {babyedwards} costs no constraints and
makes a non-curve input a compile error. The loopback test now runs its
raw input through BabyCheck first, which is what a caller with an
untagged point does.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D1w729xzwemQigkf3PCisD
OBrezhniev
force-pushed
the
fix/circomlib_buses_review
branch
from
September 29, 2026 20:08
7198ad7 to
d5f158d
Compare
OBrezhniev
force-pushed
the
fix/point2bits-requires-babyedwards
branch
from
September 29, 2026 20:08
526ffae to
61d0062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #149 (
fix/circomlib_buses_review); this PR shows only its own commits. Independent of the other stacked PRs unless stated. Full suite passes on the branch.Require babyedwards on the point Point2Bits_Strict encodes
Its contract is the encoding of a point of the curve, and its only
library caller, the EdDSA verifiers' hash output, already carries the
tag, but the input was an untagged Point, so the encoder accepted any
pair of field elements. Requiring {babyedwards} costs no constraints and
makes a non-curve input a compile error. The loopback test now runs its
raw input through BabyCheck first, which is what a caller with an
untagged point does.
🤖 Generated with Claude Code
https://claude.ai/code/session_01D1w729xzwemQigkf3PCisD