Repository navigation
Clarify that non-empty wrapped output ends with the separator - #181
Conversation
ia0
left a comment
There was a problem hiding this comment.
Thanks a lot for the fix!
If you're formalizing this, it would be simpler (in my opinion) to say that you take the output without wrapping, then chunk it (e.g. using slice::chunks()) and add a separator after each such chunk, then concatenate. By construction, chunks are not empty. In particular, the empty output has no chunks, so no separator.
|
I forgot to update the CHANGELOG. Doing so in #182 . |
This helps, thanks! |
While formalizing the documented wrap behavior, I treated “the output always ends with the separator” as a universal property, but verification failed for empty input.
I’m not sure whether this is worth clarifying in the documentation. Empty input producing empty output may be obvious to users of encoding APIs, so would adding a “non-empty output” qualification be helpful, or would it be unnecessary detail?