Repository navigation
feat(docker-build): make the Docker Hub pull login opt-out and skip it when pushing to Docker Hub - #194
Merged
Conversation
…t when pushing to Docker Hub The workflow required the `dockerhub-username`/`dockerhub-password` secrets on every call while pushing through `registry` + `username`/`password`. Two distinct concerns were conflated: - the Docker Hub login only exists to lift the anonymous pull rate limit on base images; - `username`/`password` authenticate the push against `registry`. When pushing to Docker Hub, both logins hit the same host, and the second one overwrites the first one. Worse, callers that only pass the push credentials were rejected at workflow validation time, because the Docker Hub secrets were declared `required: true`. Every change is a relaxation, so this is additive rather than breaking.
jbern0rd
marked this pull request as ready for review
October 12, 2026 12:17
thewhitewizard
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow required the
dockerhub-username/dockerhub-passwordsecrets on every callwhile pushing through
registry+username/password. Two distinct concerns were conflated:username/passwordauthenticate the push againstregistry.When pushing to Docker Hub, both logins hit the same host, and the second one overwrites
the first one. Worse, callers that only pass the push credentials were rejected at workflow
validation time, because the Docker Hub secrets were declared
required: true.Every change is a relaxation, so this is additive rather than breaking.