Repository navigation
Remove x64 exception handling code and support aarch64 - #562
Open
syntactically wants to merge 6 commits into
Open
syntactically wants to merge 6 commits into
syntactically wants to merge 6 commits into
Conversation
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 00:41
77d9f9c to
e836b62
Compare
syntactically
added this pull request to stack #563
October 20, 2026 00:42
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 20, 2026 00:56
f1bc9ae to
3975edd
Compare
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 20, 2026 17:24
5a2b052 to
a43136d
Compare
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 20, 2026 19:08
8c0eed1 to
f3e17b7
Compare
jsturtevant
reviewed
Oct 20, 2026
| len: usize, | ||
| ) -> i32 { | ||
| copy_va_mapping(image as *mut u8, len, addr, false); | ||
| copy_va_mapping(image as *mut u8, len, addr, false, true); |
Contributor
There was a problem hiding this comment.
I think it is right that this flipped due to the barrier tracker? Just calling out since it is flipped here
Member
Author
There was a problem hiding this comment.
Not sure what you meant here? If you meant the new parameter on copy_va_mapping, indeed it is needed because now an RO mapping might be the basis for a memory image and the wasmtime semantics require RO to be changed to RW in this case (whereas in the past the original image was always RW).
Contributor
There was a problem hiding this comment.
oh, I read it as a change not a new parameter 🤦. We should use enums here to make it clearer the intent of false/true in the two different parameters and it would help avoid that type of misread too.
jsturtevant
reviewed
Oct 20, 2026
syntactically
force-pushed
the
lm/aarch64
branch
from
October 20, 2026 22:16
f3e17b7 to
8c7a8fe
Compare
jsturtevant
reviewed
Oct 20, 2026
jsturtevant
reviewed
Oct 20, 2026
jsturtevant
reviewed
Oct 20, 2026
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 21, 2026 18:45
47cfe5c to
76ce45d
Compare
This requires changing the wasi-sdk builder container definition/script a little bit to make sure it works on aarch64 as well as x86_64. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
force-pushed
the
lm/aarch64
branch
5 times, most recently
from
October 21, 2026 19:29
87e2264 to
8ebab69
Compare
syntactically
force-pushed
the
lm/aarch64
branch
from
October 21, 2026 19:47
8ebab69 to
0552d20
Compare
syntactically
force-pushed
the
lm/aarch64
branch
from
October 21, 2026 19:54
0552d20 to
80d0eea
Compare
As of Hyperlight 0.18.0, all of the functionality we need is supported(ish) with architecture-independent interfaces in core Hyperlight. Remove the old architecture-specific code in favour of those new interfaces. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
force-pushed
the
lm/aarch64
branch
2 times, most recently
from
October 22, 2026 11:04
a2933c5 to
d2c6ee7
Compare
As of Hyperlight 0.18.0, all of the functionality we need is supported(ish) with architecture-independent interfaces in core Hyperlight. Remove the old architecture-specific code in favour of those new interfaces. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Not all guests are x64 anymore. Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
Signed-off-by: Lucy Menon <168595099+syntactically@users.noreply.github.com>
syntactically
force-pushed
the
lm/aarch64
branch
from
October 22, 2026 14:45
d2c6ee7 to
5213f3b
Compare
jsturtevant
approved these changes
Oct 23, 2026
jsturtevant
left a comment
jsturtevant
left a comment
Contributor
There was a problem hiding this comment.
looks like ci still needs some work but over all this LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.