Repository navigation
[path-validation] Create NoValidation without a ProblemSolver - #194
Merged
psardin001 merged 1 commit intoOct 22, 2026
Conversation
Collaborator
Author
|
The nix job fails because it builds against hpp-core 9.2.0, which doesn't install path-validation/no-validation.hh yet. It needs hpp-core > 9.2.0 (humanoid-path-planner/hpp-core#466), so it should go green after the next release or once the flake points to hpp-core devel. The ROS build passes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To get the NoValidation factory, pyhpp created a whole ProblemSolver (never freed) and looked the factory up by name in its registry. Since humanoid-path-planner/hpp-core#466 installs hpp/core/path-validation/no-validation.hh, NoValidation::create is used directly, and pyhpp no longer includes problem-solver.hh in path-validation.
Together with humanoid-path-planner/hpp-manipulation#307, this removes the remaining use of ProblemSolver in hpp-python.