Repository navigation
fix(hordeymlfile): stop declaring ci-bootstrap.sh as a binary - #5
Closed
TDannhauer wants to merge 1 commit into
Closed
TDannhauer wants to merge 1 commit into
TDannhauer wants to merge 1 commit into
Conversation
The script lives at .github/bin/ci-bootstrap.sh and is only used by CI. Listing bin/ci-bootstrap.sh makes Composer skip a file that is not in the package.
Member
|
Just delete the file in bin/ if still present. The release engine will rewrite composer.json anyway. |
🔍 CI ResultsOverall: ✅ All 10 lanes passed TL;DR: ✅ All clean: 178 tests (484 assertions) in 8 lanes, 11 files scanned, 21 files styled. Summary by PHP Version
Quality Metrics
CI powered by horde-components • View full results |
Author
|
bin/ci-bootstrap.sh is not in this repository. The script on disk is .github/bin/ci-bootstrap.sh, and .github/workflows/ci.yml runs it with There is nothing in bin/ to delete. Closing this pull request without changing composer.json, so the release engine can rewrite the bin list from bin/ on the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/ci-bootstrap.shas a Composer binary.Motivation
composer updateprints:The script is at
.github/bin/ci-bootstrap.shand is invoked from CI (bash .github/bin/ci-bootstrap.sh). There is nobin/ci-bootstrap.shin the package, and no other Horde package publishes this CI helper through Composerbin. Composer repeats the warning after autoload generation because it installs binaries again for every installed package, including thedev-FRAMEWORK_6_0branch alias.Changes
binsection fromcomposer.json..github/bin/ci-bootstrap.shand the CI workflow unchanged.Test plan
composer update horde/hordeymlfileno longer reports a skipped binary forhorde/hordeymlfilebash .github/bin/ci-bootstrap.sh