[TDannhauer]

Summary

• Load ActiveSync user flags through the mail/msgflags capability instead of unserializing the mail app's msgflags preference.
• Cache the map on the IMAP factory for the sync request.
• Return an empty map when the mail app does not provide the capability or the call fails, so message sync continues.

Motivation

Horde_Core_ActiveSync_Imap_Factory::getMsgFlags() unserialized the mail app's msgflags preference with allowed_classes => false. IMP stores IMP_Flag_* objects in that preference, so each one came back as __PHP_Incomplete_Class. PHP warned twice per synced message, and the user's labels never reached the device.

#252. The class whitelist belongs to the application that defines the objects. IMP publishes the finished map as mail/msgflags.

Changes

• getMsgFlags() calls $registry->call('mail/msgflags') when that capability exists.
• Keywords are lowercased again here, which is what the ActiveSync category lookup expects.
• A missing capability, a Horde_Exception from the call, or a non-array result is cached as an empty map. A failed call is logged at error level. A non-array result is logged at warning level.

Test plan

• phpunit test/Unit/ActiveSync/ImapFactoryMsgflagsTest.php — capability hit and cache, missing capability, API failure, non-array result, non-scalar entries
• With the IMP mail/msgflags change installed, sync a mailbox that has a user flag and confirm the device receives the label
• Confirm the ActiveSync log no longer reports __PHP_Incomplete_Class while that mailbox syncs

[TDannhauer]

Pairs with horde/imp#126, which adds the mail/msgflags capability. This pull request returns an empty map when that capability is absent.

[ralflang]

That's useful.