Repository navigation
fix: review follow-ups for v1.7.0 - #21
Conversation
…, report retention) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4156f10b7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| continue | ||
| # actionlint can't follow `$/` and we mute it there, so check the | ||
| # action exists and gets the inputs it takes here instead. | ||
| action = Path(uses[2:]) / "action.yml" |
There was a problem hiding this comment.
Support action.yaml metadata files
When a referenced local action uses the valid action.yaml filename, this hard-coded lookup reports that action.yml is missing and fails the selftest even though GitHub can execute the action. GitHub officially supports both action.yml and action.yaml, so resolve either filename and also include action.yaml in the manifest scan.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 754b6b3: a $/ ref resolves action.yml or action.yaml, and the scan covers action.yaml manifests and *.yaml workflows too. Three new tests, red before the fix.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-ups from the post-release review of v1.7.0. Nothing here needs a tag yet: the CHANGELOG entries sit under Unreleased.
check_suite.pycheck 3 now makes sure a$/.github/actions/...ref points at an action that exists and passes exactly the inputs it takes. rc2 mutes actionlint's message for$/refs, so a typo in the path or an input name would have passed Lint and broken every consumer's pytest keepers. Newtest_check_suite.py(run in Lint's selftests job) covers a misspelled path, an input the action doesn't take, and a required input that's missing.release.yml's ref-lockstep also matches quoted ("...",'...') and differently caseduses:refs. Before, those read as "no refs" and the suite file's exemption let a stale one through.Checked: the new tests went red before the fix (3 of 5) and green after; the reviewer's two mutants on a copy of the repo (
verify-pytest-shard,report-dir:) now failcheck_suite.py; the lockstep step pulled from release.yml blocks quoted, single-quoted and uppercase-owner stale refs, still passesv1.7.0and still blocksv1.7.0-rc2; actionlint, ruff, pyright and the verifier selftests clean.🤖 Generated with Claude Code