Skip to content

fix: review follow-ups for v1.7.0 - #21

Merged
homelabforge merged 2 commits into
mainfrom
fix/review-v1.7.0
Oct 6, 2026
Merged

homelabforge merged 2 commits into
mainfrom
fix/review-v1.7.0

Conversation

@homelabforge

Copy link
Copy Markdown
Owner

Follow-ups from the post-release review of v1.7.0. Nothing here needs a tag yet: the CHANGELOG entries sit under Unreleased.

  • check_suite.py check 3 now makes sure a $/.github/actions/... ref points at an action that exists and passes exactly the inputs it takes. rc2 mutes actionlint's message for $/ refs, so a typo in the path or an input name would have passed Lint and broken every consumer's pytest keepers. New test_check_suite.py (run in Lint's selftests job) covers a misspelled path, an input the action doesn't take, and a required input that's missing.
  • release.yml's ref-lockstep also matches quoted ("...", '...') and differently cased uses: refs. Before, those read as "no refs" and the suite file's exemption let a stale one through.
  • Shard report artifacts are kept 7 days instead of 1. "Re-run failed jobs" only re-uploads the shards it re-runs, so after a day the keeper found 1 of 3 reports and went red even though every shard passed.
  • README: a consumer without the pytest hook fails at "Upload shard report", not at the verify step.

Checked: the new tests went red before the fix (3 of 5) and green after; the reviewer's two mutants on a copy of the repo (verify-pytest-shard, report-dir:) now fail check_suite.py; the lockstep step pulled from release.yml blocks quoted, single-quoted and uppercase-owner stale refs, still passes v1.7.0 and still blocks v1.7.0-rc2; actionlint, ruff, pyright and the verifier selftests clean.

🤖 Generated with Claude Code

…, report retention)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T23:01:47.194075Z 4156f10 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4156f10b7f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/scripts/check_suite.py Outdated
continue
# actionlint can't follow `$/` and we mute it there, so check the
# action exists and gets the inputs it takes here instead.
action = Path(uses[2:]) / "action.yml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Support action.yaml metadata files

When a referenced local action uses the valid action.yaml filename, this hard-coded lookup reports that action.yml is missing and fails the selftest even though GitHub can execute the action. GitHub officially supports both action.yml and action.yaml, so resolve either filename and also include action.yaml in the manifest scan.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 754b6b3: a $/ ref resolves action.yml or action.yaml, and the scan covers action.yaml manifests and *.yaml workflows too. Three new tests, red before the fix.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@homelabforge
homelabforge merged commit a3ebad7 into main Oct 6, 2026
3 checks passed
@homelabforge
homelabforge deleted the fix/review-v1.7.0 branch October 6, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant