Repository navigation
fix: call verify-pytest-shards through $/ (v1.7.0-rc2) - #19
Merged
Merged
Conversation
mygarage requires SHA-pinned actions, so both keepers died on the @v1.7.0-rc1 action ref before running a step. $/ resolves to this repo at the commit the consumer called, which needs no pin and no lockstep. check_suite.py now fails on any other form of our own action ref, and actionlint (no release knows $/ yet) skips just that one message. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rc1's first canary run (homelabforge/mygarage#214) passed every shard, but both pytest keepers failed in about 4s:
mygarage has
sha_pinning_requiredon. Reusable workflows are exempt from it, actions aren't.$/.github/actions/verify-pytest-shards.$/resolves to this repo at the commit the consumer called (runner 2.336.0+), so there's no ref to pin or keep in lockstep.check_suite.pyfails on any other form of an own-action ref (tag, SHA or./). It was red on main with both call sites named..github/actionlint.yaml: actionlint 1.7.12 and older read$/as a missing ref, so that one message is ignored for$/.github/actions/...only. A duplicated key and an untrusted expression in the same files still fail.release.yml:_python-react-tests.ymlhas no internal@refleft, and the lockstep's empty-refs check would have blocked the rc2 tag on it. It's still scanned, so a stale ref added there later still blocks; it's just allowed to have none. The two callers still must have one.v1.7.0-rc2.Checked locally:
check_suite.py, actionlint (pinned 1.7.7 image and 1.7.12), the verifier selftest, and the lockstep script extracted from release.yml (passes forv1.7.0-rc2; blocksv1.7.0, a stale ref in the suite file and a caller with no ref).🤖 Generated with Claude Code