Skip to content

fix: call verify-pytest-shards through $/ (v1.7.0-rc2) - #19

Merged
homelabforge merged 2 commits into
mainfrom
fix/self-repo-action-ref
Oct 6, 2026
Merged

homelabforge merged 2 commits into
mainfrom
fix/self-repo-action-ref

Conversation

@homelabforge

@homelabforge homelabforge commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

rc1's first canary run (homelabforge/mygarage#214) passed every shard, but both pytest keepers failed in about 4s:

The action homelabforge/shared-workflows/.github/actions/verify-pytest-shards@v1.7.0-rc1 is not allowed in homelabforge/mygarage because all actions must be pinned to a full-length commit SHA.

mygarage has sha_pinning_required on. Reusable workflows are exempt from it, actions aren't.

  • Both verify steps now use $/.github/actions/verify-pytest-shards. $/ resolves to this repo at the commit the consumer called (runner 2.336.0+), so there's no ref to pin or keep in lockstep.
  • check_suite.py fails on any other form of an own-action ref (tag, SHA or ./). It was red on main with both call sites named.
  • .github/actionlint.yaml: actionlint 1.7.12 and older read $/ as a missing ref, so that one message is ignored for $/.github/actions/... only. A duplicated key and an untrusted expression in the same files still fail.
  • release.yml: _python-react-tests.yml has no internal @ref left, and the lockstep's empty-refs check would have blocked the rc2 tag on it. It's still scanned, so a stale ref added there later still blocks; it's just allowed to have none. The two callers still must have one.
  • Internal refs and CHANGELOG move to v1.7.0-rc2.

Checked locally: check_suite.py, actionlint (pinned 1.7.7 image and 1.7.12), the verifier selftest, and the lockstep script extracted from release.yml (passes for v1.7.0-rc2; blocks v1.7.0, a stale ref in the suite file and a caller with no ref).

🤖 Generated with Claude Code

homelabforge and others added 2 commits October 6, 2026 09:55
mygarage requires SHA-pinned actions, so both keepers died on the
@v1.7.0-rc1 action ref before running a step. $/ resolves to this repo at
the commit the consumer called, which needs no pin and no lockstep.

check_suite.py now fails on any other form of our own action ref, and
actionlint (no release knows $/ yet) skips just that one message.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T15:01:10.731881Z 38878fe PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@homelabforge
homelabforge merged commit 6646b64 into main Oct 6, 2026
6 checks passed
@homelabforge
homelabforge deleted the fix/self-repo-action-ref branch October 6, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant