Repository navigation
Upgrade Puppeteer to 25.16.0 and build arm64 Docker images - #692
Merged
Merged
Conversation
- Upgrade puppeteer to 25.16.0. - Fix an unhandled rejection when a page closes while a pageerror is being displayed. - Make CLI tests exit non-zero on failure and verify output files exist. - Correct the HTTP test expectations for disabled custom logic. - Add the missing samples/cli/svg_basic.svg fixture. - Build linux/amd64 and linux/arm64 images in the build-and-deploy and flow_docker workflows.
jsdom 30 requires the ESM-only @exodus/bytes, which Jest cannot require() before Node 24.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
puppeteerto 25.16.0.pageerroris being displayed (lib/browser.js). Puppeteer does not await event listeners, so the rejection escaped and shut the process down with exit code 1. This caused the intermittentTargetCloseErroron Chrome 156/157.allowCodeExecution/allowFileResourcessettings, and check the exact error response.