Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Concurrent rescans can corrupt shared downloads or cause failures, and a null JSON body bypasses required-field validation and triggers a TypeError instead of a 400 response.
2 open issues
What changed in this PR
Adds API v2 support for retrying hashcat binary scans without changing the download URL or uploading another archive, using the existing background-job runner.
Changes:
- Adds a POST helper with update-permission, access-group, and binary-type checks.
- Refreshes URL-backed archives before requesting an asynchronous scan.
- Registers and documents the endpoint, with tests for retries, pending scans, validation, and access control.
| File | Description |
|---|---|
src/inc/apiv2/helper/RescanCrackerBinaryHelperAPI.php |
Implements the rescan endpoint and access checks. |
src/inc/apiv2/common/ApiRegistry.php |
Registers the new helper. |
openapi.json |
Documents the endpoint and request/response schemas. |
ci/apiv2/test_permissions.py |
Adds the helper to permission checks. |
ci/apiv2/test_cracker.py |
Tests rescan behavior, failure recovery, and access restrictions. |
Review effort: Balanced
| } | ||
|
|
||
| try { | ||
| CrackerUtils::checkCrackerBinary($binary->getId(), $this->getCurrentUser()); |
Add validation for required 'crackerBinaryId' parameter. Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Closes #2641
Part of #2625