Skip to content

Hashcat status updated and aligned including migration on server side - #2622

Merged
s3inlc merged 5 commits into
masterfrom
2517-align-with-new-hashcat-status
Nov 12, 2026
Merged

s3inlc merged 5 commits into
masterfrom
2517-align-with-new-hashcat-status

Conversation

@s3inlc

@s3inlc s3inlc commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

backend part of #2517

Note: needs to be synchronously merged with frontend and other agents

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The status renumbering leaves the legacy mapping out of sync, causing incorrect labels and runtime errors for unmapped states; the mapping and its tests need updating.

1 open issue
What changed in this PR

Implements the backend portion of #2517 by aligning chunk states with hashcat’s status enum and migrating existing data. Deployment requires coordinated frontend and agent updates.

Changes:

  • Aligns status constants, model choices, and API schemas, including newer hashcat states.
  • Adds MySQL and PostgreSQL migrations and updates abort handling and progress images.
  • Updates test-agent states and expands protocol and enum tests.
File Description
src/​migrations/​postgres/​20261110130000_chunk-state-hashcat-enum.sql Migrates stored PostgreSQL chunk states.
src/​migrations/​mysql/​20261110130000_chunk-state-hashcat-enum.sql Migrates stored MySQL chunk states.
src/​inc/​defines/​DHashcatStatus.php Aligns constants and defines aborted states.
src/​inc/​apiv2/​helper/​GetTaskProgressImageHelperAPI.php Uses explicit aborted states for image coloring.
src/​inc/​agentapi/​schema/​SchemaRegistry.php Documents aligned agent status values.
src/​inc/​agentapi/​model/​SendProgressAction.php Handles additional abort states and renamed runtime status.
src/​inc/​agentapi/​model/​GetChunkAction.php Allows redispatch for additional stopped states.
src/​dba/​models/​generator.php Updates generated status choices.
src/​dba/​models/​Chunk.php Aligns chunk model status metadata.
src/​api/​taskimg.php Updates legacy progress-image coloring.
openapi.json Publishes aligned status values and labels.
ci/​phpunit/​inc/​utils/​AccessGroupUtilsTest.php Extends group-abort cases to new states.
ci/​phpunit/​inc/​defines/​DHashcatStatusTest.php Tests enum values and aborted-state membership.
ci/​apiv2/​test_realworld_dump.py Expects migrated states from legacy data.
ci/​apiv2/​test_agent_protocol.py Updates status values and tests new states.
ci/​apiv2/​hashtopolis_agent.py Aligns the test agent’s status enum.

Review effort: Balanced

Comment on lines +12 to +15
const RUNNING = 3;
const PAUSED = 4;
const EXHAUSTED = 5;
const CRACKED = 6;
@s3inlc s3inlc mentioned this pull request Nov 12, 2026
30 tasks done
@s3inlc
s3inlc requested a review from novasam23 November 12, 2026 09:24
@s3inlc
s3inlc marked this pull request as ready for review November 12, 2026 09:24
@s3inlc
s3inlc merged commit 357633f into master Nov 12, 2026
24 checks passed
@s3inlc
s3inlc deleted the 2517-align-with-new-hashcat-status branch November 12, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants