Repository navigation
refactor: apply conventions across session, permission, tool, and util - #249
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hakula139
force-pushed
the
refactor/services-conventions
branch
from
October 16, 2026 07:07
539d41b to
9aa773d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session, permission, tool, and utility code repeated state handling and used inconsistent layouts and test conventions. Shared helpers now own those operations, every session-listing caller uses the typed
list_paged(limit, scope)API, and first-prompt titles respect their terminal-column cap for CJK text.Not applied
indoc!.allflag, so there is noall/archivedpair to replace there.result_viewdirectly. Their section banner now names that function.Left for a follow-up
Test plan
cargo fmt --all --check,cargo build, andcargo clippy --all-targets -- -D warnings.cargo test: 2,635 unit tests (1 ignored) and 5 CLI tests pass.cargo llvm-covpasses with no uncovered changed executable lines locally.pnpm format,pnpm lint, andpnpm spellcheck.