Repository navigation
Show a background review waiting at a permission prompt - #45
Merged
Merged
Conversation
claude lists a session stopped partway through its turn at a permission prompt as status "waiting", which docket read as still working. Read it as Prompted, report it as needing the user on the dashboard and through MCP, and list such rows in a "Waiting for you" group at the top. The poll and the archive still act only on a turn that has ended. Claude-Session: https://claude.ai/code/session_01WXojGBSJfMFp3b3nGTZN2o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A background review that stops partway through its turn to ask permission for a tool still shows as working on the dashboard. claude lists that session as
state: blocked,status: waiting, and its status file holds the prompt asneeds: "approve Bash: <command>".ParseStatusonly recognizedstatus: idle, so docket dropped that need and drew no red line. A review of PostHog/posthog-python#1176 sat at one of these prompts for almost four hours before I noticed.ParseStatusnow readsstatus: waitingasBGStatus.Prompted, andNeedsUser()is true for an ended turn or a prompt. The dashboard and the MCPwaitingfield readNeedsUser(), and the dashboard lists those rows in a new "Waiting for you" group at the top. The poll's GitHub read and the archive'sclaude stopstill act only on an ended turn, because a prompted session hasn't posted anything and stopping it would delete its clone mid-turn. Two tests fail if either check switches toNeedsUser().I haven't checked whether a prompt inside one of review-code's sub-agents also shows the main session as
waiting.Test plan
bin/testpasses.ParseStatus,Progress, andprogressFor. It read as prompted, with claude's "approve Bash: …" text as the need.https://claude.ai/code/session_01WXojGBSJfMFp3b3nGTZN2o