[larouxn]

To ensure we don't encounter representable gem based MultiJson deprecation warnings I am proposing we raise the representable gem version requirement from '~> 3.0' to '~> 3.3', '>= 3.3.1' and multi_json gem version requirement from '~> 1.11' to '~> 1.21', '>= 1.21.2'.

Relevant links

• https://github.com/trailblazer/representable/blob/a0612bf545f742fe3f3be9d554cbae18bea10b75/CHANGES.md#330
• https://github.com/sferik/multi_json/blob/c44e92e886e6479f60ff1769e06db7eb01c0abf2/CHANGELOG.md#1210
• Crash on load: multi_json is not part of the bundle. Add it to your Gemfile. #26611 (comment)

[seuros]

bump multi_json to '~> 1.21'

[torreypayne]

@larouxn LGTM to bump the dependencies for maintenance, but are you sure this update actually clears the warnings? Can you repro?

[larouxn]

@larouxn LGTM to bump the dependencies for maintenance, but are you sure this update actually clears the warnings? Can you repro?

Thanks for the review! Good call. Unfortunately I believe that due to this (temporary I hope) compatibility fix some deprecation warnings will still appear. I suppose until representable drops that we will continue to see some deprecation warnings, despite representable v3.3.0 specifically noting it will: "Fix deprecations with MultiJson.".

https://github.com/trailblazer/representable/blob/a0612bf545f742fe3f3be9d554cbae18bea10b75/lib/representable/json.rb#L9-L18

Reproduction Test (disclaimer: LLM assisted)

Running this script with representable 3.2.0 vs 3.3.0 demonstrates the behaviour:

# test_repro.rb
require "multi_json"       # 1.21.1
require "representable/json"

class Model
  attr_accessor :name
  def initialize(name = nil); @name = name; end
end

module ModelRepresenter
  include Representable::JSON
  property :name
end

m = Model.new("Alice")
m.extend(ModelRepresenter).to_json
Model.new.extend(ModelRepresenter).from_json('{"name":"Bob"}')

Result with representable 3.2.0 (ruby -W:deprecated test_repro.rb):

The MultiJson constant is deprecated and will be removed in v2.0. Use MultiJSON instead.
MultiJSON.dump is deprecated and will be removed in v2.0. Use MultiJSON.generate instead.
MultiJSON.load is deprecated and will be removed in v2.0. Use MultiJSON.parse instead.

Result with representable 3.3.0 (ruby -W:deprecated test_repro.rb):

The MultiJson constant is deprecated and will be removed in v2.0. Use MultiJSON instead.
MultiJSON.dump is deprecated and will be removed in v2.0. Use MultiJSON.generate instead.
MultiJSON.load is deprecated and will be removed in v2.0. Use MultiJSON.parse instead.

Note: If we remove Representable::JSON::MultiJSON from representable so it actually delegates to top-level ::MultiJSON, all warnings should disappear completely.

[larouxn]

Rebased on latest main to pick up potential fixes from #28043.

[quartzmo]

Thanks for your patience with this review, and sorry for the delays. If you don't have time for these two tweaks, no problem: I'm happy to push them to your branch in a couple of days so we can get this merged.

[larouxn]

👋 @quartzmo, thanks a bunch for the review and good call on setting the minimum allowed versions in the Gemspec for multi_json and representable. I have made both changes and rebased on latest main.

[quartzmo]

Thank you @larouxn (and @seuros reviewing) for this PR, and also to both of you with the ongoing effort for #28001. We really appreciate it.