Repository navigation
Conversation
Without a measurement ID, useGtag still configured gtag with an undefined ID and requested gtag/js?id=undefined. Keep the dataLayer stub so gtag() calls are harmless, but return before configuring and injecting the script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the site is built without
GA_MEASUREMENT_ID(local development, forks, preview builds), every page requestshttps://googletagmanager.com/gtag/js?id=undefinedand configures gtag with anundefinedmeasurement ID.Cause
useGtagalways callsgtag("config", process.env.GA_MEASUREMENT_ID!, ...)and injects the gtag.js script, with no check that the ID is set.Fix
Return early from the default snippet when
GA_MEASUREMENT_IDis unset. ThedataLayer/gtagstub is still installed, so existinggtag()calls (page views, events) remain harmless no-ops. Builds that set the ID behave exactly as before.How tested
yarn check-types: no new errors (the 3 existing errors onmainare unrelated).gatsby buildsucceeds.GA_MEASUREMENT_ID, there is nogtag/js?id=undefinedrequest.