Skip to content

Remove sunset BOM versions and update support link in README #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pattersonlois wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove sunset BOM versions and update support link in README #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6a5fd4
Remove sunset stub references in BOM and update README support link
pattersonlois Nov 4, 2026
f606b91
Derive google-ads-stubs-v* BOM constraints dynamically from subprojects
pattersonlois Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop

@Aamanuel01 Aamanuel01 Nov 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support

Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ Our documentation is available [here](https://developers.google.com/google-ads/a

- https://developers.google.com/google-ads/api/docs

### Support forum
### Support

- https://groups.google.com/forum/#!forum/adwords-api
- https://developers.google.com/google-ads/api/support

### Authors

Expand Down
16 changes: 7 additions & 9 deletions google-ads-bom/build.gradle
View file
Open in desktop

@Aamanuel01 Aamanuel01 Nov 7, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependencies {
// This makes this BOM inherit all dependency versions from the Google Cloud
// BOM. This version is determined based on the current used version of
// google-cloud-shared-dependencies.
api(platform("com.google.cloud:libraries-bom:26.81.0"))

// Add constraints for all of this project's artifacts.
constraints {
    rootProject.subprojects
            .findAll { it.name.startsWith("google-ads-stubs-v") }
            .each { api it }
    api project(":google-ads")
    api project(":google-ads-codegen")
    api "com.google.api-ads:google-ads-shadowjar:${version}"
}

}

Original file line number Diff line number Diff line change
Expand Up @@ -130,16 +130,14 @@ dependencies {

// Add constraints for all of this project's artifacts.
constraints {
api "com.google.api-ads:google-ads-stubs-v26:${version}"
api "com.google.api-ads:google-ads-stubs-v25:${version}"
api "com.google.api-ads:google-ads-stubs-v24:${version}"
api "com.google.api-ads:google-ads:${version}"
api "com.google.api-ads:google-ads-codegen:${version}"
api project(":google-ads")
api project(":google-ads-codegen")
// Uses string coordinates because :google-ads-shadowjar is excluded when -Pfastbuild is set.
api "com.google.api-ads:google-ads-shadowjar:${version}"
api "com.google.api-ads:google-ads-stubs-v21:${version}"
api "com.google.api-ads:google-ads-stubs-v22:${version}"
api "com.google.api-ads:google-ads-stubs-v23:${version}"
api "com.google.api-ads:google-ads-stubs-v24:${version}"
rootProject.subprojects

@jradcliff jradcliff Nov 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we keep this as-is. Each version addition or subtraction is a one-time event, so I'd rather just keep this as a static list, same as the root settings.gradle. If we instead go with this change, the dependency list becomes dynamic, which could lead to other problems.

If we're missing duplicates and sunset versions during code reviews, I'd prefer we just make a point of reminding reviewers to pay closer attention to this file.

@pattersonlois pattersonlois Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had cl/1015794471 for the second part with primordial, but I reverted it.

.findAll { it.name.startsWith("google-ads-stubs-v") }
.sort { it.name.replace("google-ads-stubs-v", "") as Integer }
.each { api it }
}
}

Expand Down
Loading