Repository navigation
Synchronize GwpAsanState error recording across concurrent threads. - #1792
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
`GwpAsanState` stored its fields as non-atomic members and overwrote them unconditionally on every `Record*` call. If two threads triggered GWP-ASan errors concurrently before process termination, they raced on `type_`, `faulting_address_`, and `alloc_stack_`/`dealloc_stack_`, corrupting the crash state read by the crash handler. Gate `Record*` calls with `Claim()` (`recording_.exchange(true, std::memory_order_acq_rel)`) so the first crashing thread wins, and publish `type_` with `std::memory_order_release` only after `CopyStack` finishes so `error_type()` (`std::memory_order_acquire`) observes complete stack traces. PiperOrigin-RevId: 1011015763
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize GwpAsanState error recording across concurrent threads.
GwpAsanStatestored its fields as non-atomic members and overwrote them unconditionally on everyRecord*call. If two threads triggered GWP-ASan errors concurrently before process termination, they raced ontype_,faulting_address_, andalloc_stack_/dealloc_stack_, corrupting the crash state read by the crash handler.Gate
Record*calls withClaim()(recording_.exchange(true, std::memory_order_acq_rel)) so the first crashing thread wins, and publishtype_withstd::memory_order_releaseonly afterCopyStackfinishes soerror_type()(std::memory_order_acquire) observes complete stack traces.